Fixing filters with uppercase letters #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Filters that are using uppercase characters are broken as the
lowercase()
method is being executed to the name before registering them into theSimpleLibrary
.They are broken because in the
fetch
method the filter name is just lowercased before being compared with the existing ones, but not before adding them to the library, so what's happening is that:filterName
.filtername
.There were two solutions:
put
into the HashMap.I chose the second option as I didn't see any reason for the restriction.
I added one test and the patch is backwards compatible, as filters with uppercase characters were not usable before.