Skip to content

Correctly report column positions of syntax errors #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2018

Conversation

boulter
Copy link
Contributor

@boulter boulter commented Apr 17, 2018

Follows up on #152.

The syntax exceptions report only the position of the error within the expression, not within the entire rendered content. This adds the interpreter column position and the exception position together to report accurate column positions.

@boulter boulter requested review from pfarrel and mattcoley April 17, 2018 19:28
Copy link
Collaborator

@mattcoley mattcoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@corymartin
Copy link

🔢 Thank you!

@boulter boulter merged commit 705d0f0 into master Apr 17, 2018
@boulter boulter deleted the correctly-report-column-positions-of-syntax-errors branch April 17, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants