Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling macros with kwargs #208

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Conversation

leromarinvit
Copy link

The kwargs variable currently contains the named parameters listed in a macro's definition, whereas the Jinja documentation says:

Like varargs but for keyword arguments. All unconsumed keyword arguments are stored in this special variable.

python-jinja2 behaves accordingly as well.

@codecov-io
Copy link

Codecov Report

Merging #208 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #208      +/-   ##
============================================
+ Coverage      71.3%   71.35%   +0.04%     
- Complexity     1351     1352       +1     
============================================
  Files           215      215              
  Lines          4280     4280              
  Branches        682      682              
============================================
+ Hits           3052     3054       +2     
+ Misses          986      985       -1     
+ Partials        242      241       -1
Impacted Files Coverage Δ Complexity Δ
...java/com/hubspot/jinjava/lib/fn/MacroFunction.java 96.42% <100%> (ø) 9 <0> (ø) ⬇️
...hubspot/jinjava/el/ext/AbstractCallableMethod.java 88.23% <0%> (+5.88%) 11% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8957e9...c36b42d. Read the comment docs.

@boulter boulter merged commit d2088d6 into HubSpot:master Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants