Detect fromTag cycle. #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcoley
reviewed
Aug 16, 2018
| public void pushFromStack(String path, int lineNumber, int startPosition) { | ||
| fromStack.push(path, lineNumber, startPosition); | ||
| } | ||
| public void popFromStack() { |
| @@ -54,6 +56,13 @@ public void importedContextExposesVars() { | |||
| .contains("wrap-padding: padding-left:42px;padding-right:42px"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void importedCycleDected() { | |||
There was a problem hiding this comment.
Is it possible for A to import from B which imports from C which imports from A? If so can we have a test to make sure it catches this cycle as well?
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
============================================
+ Coverage 71.28% 71.44% +0.16%
- Complexity 1365 1373 +8
============================================
Files 217 218 +1
Lines 4315 4336 +21
Branches 687 689 +2
============================================
+ Hits 3076 3098 +22
Misses 998 998
+ Partials 241 240 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursive fromTag will cause stack overflow.