Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle large values in range function #265

Merged
merged 2 commits into from
Jan 5, 2019
Merged

handle large values in range function #265

merged 2 commits into from
Jan 5, 2019

Conversation

boulter
Copy link
Contributor

@boulter boulter commented Jan 3, 2019

Fixes #263 by defaulting numeric, out of range values in the range function to start + RANGE_LIMIT

@codecov-io
Copy link

Codecov Report

Merging #265 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #265      +/-   ##
============================================
- Coverage     72.05%   72.04%   -0.01%     
- Complexity     1453     1455       +2     
============================================
  Files           231      231              
  Lines          4534     4536       +2     
  Branches        718      721       +3     
============================================
+ Hits           3267     3268       +1     
  Misses         1014     1014              
- Partials        253      254       +1
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/hubspot/jinjava/lib/fn/Functions.java 84.12% <85.71%> (-0.56%) 38 <0> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ccadb...ba32135. Read the comment docs.

@boulter boulter changed the title convert ints in range to longs handle large values in range function Jan 3, 2019
@boulter
Copy link
Contributor Author

boulter commented Jan 4, 2019

@MosheElisha is this what you expected?

@MosheElisha
Copy link

@boulter Yes. That's great! Thanks!

@boulter boulter merged commit 3d487dd into master Jan 5, 2019
@boulter boulter deleted the long-range-limits branch January 5, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants