Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not execute elif statements if another statement has already been executed #268

Merged
merged 5 commits into from
Jan 8, 2019
Merged

Do not execute elif statements if another statement has already been executed #268

merged 5 commits into from
Jan 8, 2019

Conversation

mattcoley
Copy link
Collaborator

@mattcoley mattcoley commented Jan 8, 2019 •
edited by boulter
Loading

Important fix after #264

@boulter boulter changed the title Reproduce conditional bug in macro. Do not execute elif statements if another statement has already been executed Jan 8, 2019
@boulter boulter requested a review from hs-lsong January 8, 2019 18:55
hs-lsong
hs-lsong approved these changes Jan 8, 2019
View reviewed changes
Copy link
Collaborator

@hs-lsong hs-lsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boulter boulter merged commit 3412558 into master Jan 8, 2019
@boulter boulter deleted the macro-conditional-bug branch January 8, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hs-lsong hs-lsong hs-lsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattcoley @hs-lsong @boulter @jboulter