Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace functionality #306

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Add namespace functionality #306

merged 2 commits into from
Apr 30, 2021

Conversation

pastorcmentarny
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #306 into master will decrease coverage by 0.33%.
The diff coverage is 97.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #306      +/-   ##
============================================
- Coverage     71.58%   71.24%   -0.34%     
- Complexity     1553     1565      +12     
============================================
  Files           239      240       +1     
  Lines          4863     4928      +65     
  Branches        787      789       +2     
============================================
+ Hits           3481     3511      +30     
- Misses         1097     1132      +35     
  Partials        285      285
Impacted Files Coverage Δ Complexity Δ
...hubspot/jinjava/el/JinjavaInterpreterResolver.java 76.57% <100%> (+0.42%) 29 <0> (+1) ⬆️
.../hubspot/jinjava/interpret/JinjavaInterpreter.java 79.88% <100%> (ø) 53 <0> (ø) ⬇️
...va/com/hubspot/jinjava/lib/fn/FunctionLibrary.java 94.11% <100%> (+0.36%) 3 <0> (ø) ⬇️
...in/java/com/hubspot/jinjava/interpret/Context.java 79.77% <100%> (+0.22%) 82 <1> (+1) ⬆️
.../main/java/com/hubspot/jinjava/lib/tag/SetTag.java 84.21% <100%> (+10.29%) 11 <4> (+4) ⬆️
...ain/java/com/hubspot/jinjava/lib/fn/Functions.java 84.61% <100%> (+0.48%) 40 <2> (+2) ⬆️
...in/java/com/hubspot/jinjava/objects/Namespace.java 85.71% <85.71%> (ø) 4 <4> (?)
...ava/com/hubspot/jinjava/doc/JinjavaDocFactory.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../java/com/hubspot/jinjava/doc/JinjavaDocParam.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...n/java/com/hubspot/jinjava/doc/JinjavaDocItem.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d2ee0...10bf69d. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #306 into master will decrease coverage by 1.04%.
The diff coverage is 97.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #306      +/-   ##
============================================
- Coverage     72.28%   71.24%   -1.05%     
- Complexity     1497     1565      +68     
============================================
  Files           234      240       +6     
  Lines          4648     4928     +280     
  Branches        739      789      +50     
============================================
+ Hits           3360     3511     +151     
- Misses         1033     1132      +99     
- Partials        255      285      +30     
Impacted Files Coverage Δ Complexity Δ
...in/java/com/hubspot/jinjava/objects/Namespace.java 85.71% <85.71%> (ø) 4.00 <4.00> (?)
...hubspot/jinjava/el/JinjavaInterpreterResolver.java 76.57% <100.00%> (-0.35%) 29.00 <0.00> (+3.00) ⬇️
...in/java/com/hubspot/jinjava/interpret/Context.java 79.77% <100.00%> (+0.22%) 82.00 <1.00> (+1.00)
.../hubspot/jinjava/interpret/JinjavaInterpreter.java 79.88% <100.00%> (ø) 53.00 <0.00> (ø)
...va/com/hubspot/jinjava/lib/fn/FunctionLibrary.java 94.11% <100.00%> (+0.36%) 3.00 <0.00> (ø)
...ain/java/com/hubspot/jinjava/lib/fn/Functions.java 84.61% <100.00%> (+0.48%) 40.00 <2.00> (+2.00)
.../main/java/com/hubspot/jinjava/lib/tag/SetTag.java 84.21% <100.00%> (+10.29%) 11.00 <4.00> (+4.00)
...ot/jinjava/interpret/IncludeTagCycleException.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...n/java/com/hubspot/jinjava/lib/tag/IncludeTag.java 59.09% <0.00%> (-24.91%) 4.00% <0.00%> (ø%)
...com/hubspot/jinjava/lib/filter/FromJsonFilter.java 80.00% <0.00%> (-20.00%) 5.00% <0.00%> (ø%)
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815fdfd...10bf69d. Read the comment docs.

@pastorcmentarny
Copy link
Author

I am glad to hear that it will be added :D.

@jasmith-hs jasmith-hs merged commit 9d656d4 into HubSpot:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants