Rewrite sort filter to address several problems. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 23, 2019 17:18
mattcoley
force-pushed
the
rewrite-sort-filter
branch
from
7bd08dc to
1a5e687
Compare
mattcoley
changed the title
added 2 commits
April 23, 2019 17:30
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
============================================
+ Coverage 71.32% 71.38% +0.05%
- Complexity 1558 1569 +11
============================================
Files 239 239
Lines 4918 4921 +3
Branches 793 794 +1
============================================
+ Hits 3508 3513 +5
+ Misses 1126 1124 -2
Partials 284 284
Continue to review full report at Codecov.
|
boulter
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So a few problems with the previous implementation addressed in this PR:
If an object in the list is null, we would throw an unhelpful NPE.
If the attribute is null, we just pretend it wasn't passed in in the first place.
If the attribute resolution is null, we would throw an unhelpful NPE.
We would do attribute resolution on every object comparison resulting in O(nlogn) resolutions instead of O(n).
To fix we now throw useful error messages. We also use streams and a keyExtractor method for the comparison so attribute resolution only happens once per object.