Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when there is no matching start tag for an end tag #326

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

liamrharwood
Copy link
Contributor

The following syntax is allowed by Jinjava:

{% if true %}
foo
{% endif %}
{% endif %}

This causes no issues in isolation, but can result in mismatched end tags when inserted in the middle of a template such as in a generated module_attribute tag. Adding a warning will help make this danger more apparent and prevent cases such as this from causing problems.

@liamrharwood liamrharwood merged commit ce57093 into master Apr 30, 2019
@liamrharwood liamrharwood deleted the warn-missing-start-tag branch April 30, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants