Upgrade to newer basepom #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaber
commented
May 30, 2019
| @@ -94,6 +94,6 @@ public void itConvertsNominativeFormats() { | |||
| ZonedDateTime zonedDateTime = ZonedDateTime.parse("2019-06-06T14:22:00.000+00:00"); | |||
|
|
|||
| assertThat(StrftimeFormatter.formatter("%OB").withLocale(Locale.forLanguageTag("ru")).format(zonedDateTime)) | |||
| .isEqualTo("Июнь"); | |||
| .isIn("Июнь", "июнь"); | |||
There was a problem hiding this comment.
Seems like there was a minor change with Java 11; I made the test accept either format so it still works on Java 8
There was a problem hiding this comment.
июнь is correct, it was a bug with Java 8.
|
Will it still target Java 8 bytecode? |
|
Yup |
mattcoley
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to new basepom and also builds on Java 11
@jboulter @boulter