Add dummy object for validation mode. #341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are in validation mode and we have a zero-size loop, we used to convert
[]
to[0]
so we can validate the for loop body by resolving it. The issue is as so looking at some typical code:If
get_objects()
returns an empty list, we forcetest
to be0
which will cause validation errors in the for loop body where it expects a different object type returned fromget_objects()
.The best solution I can think of is to return a
DummyObject
instead of0
. The dummy object will resolve all properties (so they don't throw errors in cases like{{ test.property.evenDeeperProperty }}
) and can be coerced to any type (so they don't throw errors in cases like{{ test.numProperty + 100 }}
).