Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #532
This PR unstubs the
getNewlyDeferredFunctionImages()
method in the EagerTagDecorator class by introducing an EagerMacroFunction wrapper class, which wraps the logic of a MacroFunction to be able to reconstruct a partially evaluated image of the macro function to output before a deferred call of the said macro function.Since macro functions can either be called directly (when they are stored as a global macro function), or with an imported alias, such as
{% import path as simple %} {{ simple.the_macro() }}
, there needs to be a way to create a macro in this way. So I formalised this aliased macro importing by calling it a local macro, rather than a global macro (because it's only local to the alias). TheMacroTag
now allows for a macro function to be stored in such a way:{% macro parent_alias.macro_name() %}
, which allows for global or local macro functions on the context to be re-output before they're called.For example:
Would result in an output similar to the following if doing eager execution (adjusted for readability):
cc @boulter @Joeoh