Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch concurrent modification in for loop #750

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Catch concurrent modification in for loop #750

merged 2 commits into from
Sep 23, 2021

Conversation

mattcoley
Copy link
Collaborator

Catches ConcurrentModificationException that can happen in the for loop and adds an FATAL template error.

jasmith-hs
jasmith-hs approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@jasmith-hs jasmith-hs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better than reworking how for loops are processed. At least for HubSpot

@mattcoley mattcoley merged commit 0c7a9c2 into master Sep 23, 2021
@mattcoley mattcoley deleted the catch-concurrent branch September 23, 2021 18:35
@ssalonen ssalonen mentioned this pull request Aug 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmith-hs jasmith-hs jasmith-hs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattcoley @jasmith-hs