Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return long value when under min int value from IntFilter #908

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Return long value when under min int value from IntFilter #908

merged 1 commit into from
Aug 30, 2022

Conversation

AlpriElse
Copy link
Contributor

Returning long values when over Integer.MAX_VALUE was added in this pr:
#315

This pr also makes sure this also happens when we underflow.

@AlpriElse AlpriElse requested a review from mattcoley August 30, 2022 13:54
@mattcoley
Copy link
Collaborator

mattcoley commented Aug 30, 2022 •
edited
Loading

I am confused how this will solve the ticket. Weren't we getting overflow for large values?

@AlpriElse
Copy link
Contributor Author

AlpriElse commented Aug 30, 2022 •
edited
Loading

I am confused how this will solve the ticket. Weren't we getting overflow for large values?

There is actually two problems that was in the JIRA.

  1. The IntFilter underflowing eg. -42595200000|int -> 354472960
  2. The DateTimeFormatFilter not properly converting -42595200000L also presumably due to underflow because we are interpreting the value as an Integer.

This PR resolves the first issue

@AlpriElse AlpriElse merged commit 4e09bf9 into master Aug 30, 2022
@AlpriElse AlpriElse deleted the longs-for-small-values branch August 30, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcoley mattcoley mattcoley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlpriElse @mattcoley