Allow globs without files to still fail check. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If prettier sees that a glob doesn't find any files it currently will not fail as the status is 2 but one of the globs didn't find any files. These changes allow for a final method to be run when the prettier process completes to fail if files were found to not pass the code style check even if a glob didn't find any files. This can happen if you have a sub module that doesn't have any *.html files but other modules do. As part of this, the glob suffixes are used to retrieve the list of files that failed the check to be output.
|
@jhaber Any chance you'll have some time to look at these changes this week? |
|
@jhaber Any chance you'll have time to look at these changes? |
|
@jhaber Happy to incorporate any feedback on this PR. I'd love to get this in soon so we can start checking on all files. |
|
Is this still an issue, now that #57 is integrated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If prettier sees that a glob doesn't find any files it currently will not
fail as the status is 2 but one of the globs didn't find any files.
These changes allow for a final method to be run when
the prettier process completes to fail if files were found to not
pass the code style check even if a glob didn't find any files.
This can happen if you have a sub module that doesn't have any *.html
files but other modules do.
As part of this, the glob suffixes are used to retrieve the list
of files that failed the check to be output. Fixing #49