Download node and prettier, rather than bundling #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big rewrite to the plugin. Rather than bundling node, the plugin will download it from https://nodejs.org/dist/ as needed. And then rather than bundling prettier-java, it will use the npm binary inside of the node download to
npm install prettier-plugin-java@{requestedVersion}This means we won't have make code changes and releases to this plugin in order to keep up with node or prettier-java releases. I also added support for downloading Mac arm64 binaries of node, which runs much faster on M1 macbooks than the x64 binaries.The main breaking change is that the beta versions of prettier-java, such as 0.8.2-hubspot are gone, so users will need to migrate to a proper prettier-java release before upgrading to this version
@stevegutz @snommit-mit @Xcelled @kmclarnon