Remove Guava dependency #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaber
reviewed
Aug 7, 2023
...gration-tests/src/test/java/com/hubspot/maven/plugins/prettier/AbstractPrettierMojoTest.java
Outdated
Show resolved
Hide resolved
jhaber
reviewed
Aug 7, 2023
...gration-tests/src/test/java/com/hubspot/maven/plugins/prettier/AbstractPrettierMojoTest.java
Outdated
Show resolved
Hide resolved
jhaber
reviewed
Aug 7, 2023
...-maven-plugin/src/main/java/com/hubspot/maven/plugins/prettier/internal/PrettierPatcher.java
Show resolved
Hide resolved
|
Thanks for the PR, I left a few comments. Just curious if the Guava dependency was causing any particular issues? (if so, we have other plugins we may want to remove it from) |
|
Thanks for taking the time to review, and most importantly for catching my careless mistakes! To clarify, there was nothing in the Guava dependency causing any issues, I simply thought that I could reduce the plugin's dependency footprint by replacing Guava with newer Java functionality. Because of that, feel free to close this PR if you're uninterested -- its only real improvement is the reduction of the dependency footprint (the NIO changes could offer a slight performance improvement). |
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the few Guava uses with standard Java equivalents, and remove Guava as a dependency (to reduce the plugin's footprint).