Set animation-fill-mode to fix .vex-closing flashing in IE 11 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't have any effects in other browsers, does it? I read through the MDN documentation for that property and that seems the case but I'm not a CSS animation expert. PR looks good, can you confirm for me that this doesn't cause changes in other browsers? I'll merge in after. |
|
No change in other browsers. I'm already using this in my own CSS without issue. |
|
Looks like someone's reported this as an issue before; you can close #216 after merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE 11 usually has a frame or two between the end of .vex-closing's animation and the removal of the vex from the DOM, which causes the user to see a flash of the vex in its fully-open state. This is fixed by setting the
animation-fill-modeproperty toforwards, which this commit adds to theanimationshorthand.