Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue when
vex.baseClassNames.content
was set to a string containing multiple classes.For example...
vex.baseClassNames.content = 'vex-content'
(works fine)vs.
vex.baseClassNames.content = 'vex-content vex-content-auto hs-modal'
(breaks)The culprit was
$(@).parents(".#{vex.baseClassNames.content}")
which tries to form a selector'.vex-content vex-content-auto hs-modal'
Needless to say, this doesn't work.The solution was to add a utility method
getBaseClassesAsSelector
to vex. It's job is to simply split/join and return our properly formatted selector.vex-content.vex-content-auto.hs-modal
@timmfin @zackbloom @gusvargas @b-ash