Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't publish a scene with no models in it #1137

Open
Exairnous opened this issue May 6, 2021 · 6 comments · May be fixed by #1293
Open

Can't publish a scene with no models in it #1137

Exairnous opened this issue May 6, 2021 · 6 comments · May be fixed by #1293

Comments

@Exairnous
Copy link
Contributor

Sometimes I want to publish scenes with either nothing in it or just a skybox, but the scene will not publish and shows an error of "e is not iterable". The reason I want scenes with no objects is usually so that I can have a stable baseline for testing performance of objects added into a room, or I'm testing skyboxes, stuff like that. This appears to be a fairly recent regression, markun mentioned it in the spoke discord channel on April 20th, but I think it was working not too long before that.
@Softvision-GeluHaiduc
Copy link
Contributor

I can confirm this behavior on Firefox and Chrome as well using windows 10.
This issue is not reproducible on Hubs Cloud so I also think it is a regression.

@Exairnous Exairnous mentioned this issue May 31, 2021
Closed
@matthewbcool matthewbcool mentioned this issue Aug 2, 2021
Closed
@matthewbcool
Copy link
Contributor

I'm able to reproduce this error in chrome with a video and no models.

@yalegria
Copy link

yalegria commented Oct 7, 2021 •
edited
Loading

I experienced a similar issue with a Spoke project that was published and working for a while. First the issue appeared when I tried to create a room with the scene, and got a "Fail to load scene" message. There were some errors in the console but I didn't see any relevant or known issues that will lead me to troubleshoot something.

Then I tried to re-publish the project on Spoke, but I got an error "Error Publishing Project: e is undefined". After doing research on this, couldn't find anything, but this was mentioned on the Spoke discord channel on 9/14/21, which the thread suggest that now scenes need to have at least one model (.glb) file on the scene.

Questions:

  • When this new requirement was set and why is now necessary?
  • How can we be aware of these changes in the future?

@matthewbcool
Copy link
Contributor

This is a bug and not an intentional feature, we don't have a timeline on a fix at this time.

@Exairnous Exairnous mentioned this issue Jan 26, 2022
Closed
Exairnous added a commit to Exairnous/Spoke that referenced this issue Mar 19, 2024
@Exairnous
Fix publishing scenes with no models i.e. the e is not iterable error.
cf8860d 
Fixes Hubs-Foundation#1137
Skip trying to remap the node refs for materials if there aren't any materials in the scene.
Add the length of the JSON chunk to the header when there is no binary buffer so that a valid
GLB file can be generated.
@Exairnous Exairnous linked a pull request Mar 19, 2024 that will close this issue
Open
@jywarren
Copy link

Thank you so much! So looking forward to this fix. <3

@Exairnous
Copy link
Contributor Author

Exairnous commented Mar 20, 2024 •
edited
Loading

You're welcome. Me too. It'll be nice to see this finally fixed 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix publishing scenes with no models i.e. the e is not iterable error. Exairnous/Spoke
5 participants
@jywarren @matthewbcool @yalegria @Exairnous @Softvision-GeluHaiduc