Fixes for Daydream #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianpeiris
approved these changes
Nov 21, 2017
public/room.html
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| <head> | |||
| <title>Mozilla Mixed Reality Social Client</title> | |||
| <script src="https://webrtc.github.io/adapter/adapter-latest.js"></script> | |||
There was a problem hiding this comment.
Should we really point to latest?
| this.accelerationInput.setX(event.detail); | ||
| } else { | ||
| this.accelerationInput.setX(0); | ||
| } |
There was a problem hiding this comment.
Is this a bug in input-mapping that we should submit a PR for? Maybe put a TODO in here.
| @@ -106,6 +106,7 @@ AFRAME.registerComponent("hand-controls2", { | |||
| el.setAttribute("vive-controls", controlConfiguration); | |||
There was a problem hiding this comment.
(why is this component called hand-controls2? Surely it deserves a better name)
There was a problem hiding this comment.
I think its a direct extension of the aframe built in component hand-controls . It's likely something we might want to land upstream but we don't know exactly what we want yet so its not worth maintaining a separate fork of aframe over. Thus hand-controls2 was born.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtual-gamepad-controlscomponent.daydream-controlscomponent tohand-controls2component.offline=truequery string option so you can get past the loading screen when offline.