-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for Firefox video play performance issue #4210
Add workaround for Firefox video play performance issue #4210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should double check that this doesn't cause any issues in Firefox reality or Firefox for android but otherwise looks good to me. This is an awesomely simple "fix" to a big problem!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My tests on various devices wiith a 4K video (https://brianpeiris.github.io/test-media/big-buck-bunny-4k-short.mp4):
RGB | RGBA | |
---|---|---|
FF on Windows | 6fps | 60fps |
FF on Mac | 20fps | 60fps |
FF on Linux | 14fps | 14fps |
FxR on Quest | 35fps | 35fps |
Firefox on Android: Could not test due to existing bug where videos don't render at all :( #4213
We should look at Android later, but the significant benefit on Windows and Mac makes this well worth it. Nice work!!
The best video performance I have had was with the new Microsoft Edge
browser.
60 FPS even while screen sharing a video from a tab with either Youtube or
Netflix.
I was able to use VB-Audio virtual cable as a loopback to send the audio
through the mic so it was received perfectly in Hubs.
…On Sat, May 1, 2021 at 1:00 AM Brian Peiris ***@***.***> wrote:
***@***.**** approved this pull request.
My tests on various devices wiith a 4K video:
RGB RGBA
FF on Windows 6fps 60fps
FF on Mac 20fps 60fps
FF on Linux 14fps 14fps
FxR on Quest 35fps 35fps
Firefox on Android: Could not test due to existing bug where videos don't
render at all :( #4213 <#4213>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4210 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATDKS7BG3QJMKUMYYF64SLTLODFZANCNFSM435IQSCA>
.
|
Thanks for the test! I would merge this PR. |
It works even better when Edge is capturing video from Firefox. Avoid
Chrome.
…On Mon, May 3, 2021 at 12:06 PM Takahiro ***@***.***> wrote:
Merged #4210 <#4210> into master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4210 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATDKSZXGBZK267GA5FEGPLTL3CZDANCNFSM435IQSCA>
.
|
From #3470 (comment) and the following comments.
Firefox seems to have video play (or decode) performance issue. The FPS number becomes very bad if videos are played in viewport on Firefox.
In Three.js repo, it has been reported that somehow setting RGBA format to video texture improves the performance very well. (I guess it can avoid slow decoding in browser?).
The ticket has been opened for the performance issue in bugzilla but I don't think it can be resolved soon. So I would like to suggest to set RGBA format for Firefox as workaround so far.
11.2MB mp4 video + desktop Windows + NVIDIA GeForce GTX 1080.
Ideally we should test on more platforms (Mac, Mobile, other graphics boards and so on). I would be happy if you test on your end, too.