Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable chrome AEC hack by default #4227

Merged
merged 1 commit into from
May 6, 2021
Merged

Disable chrome AEC hack by default #4227

merged 1 commit into from
May 6, 2021

Conversation

netpro2k
Copy link
Contributor

@netpro2k netpro2k commented May 5, 2021

This disables the workaround that was added to Chrome in #2361 by default as it significantly reduces audio quality and largely breaks audio spatialization. It remains as a preference but we should plan to remove it once a fix lands upstream (which is slated for this year) https://bugs.chromium.org/p/chromium/issues/detail?id=687574

It is unclear if this was always an issue or something that changed in Chrome that caused this workaround to cause other issues... I am hoping for my own sanity that its the later, though it has been an issue since at least January since it was mentioned by a user on the original PR #2361 (comment)

Incidentally adds ability to the preference screen to have dependent properties:
image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@johnshaughnessy johnshaughnessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants