Disable chrome AEC hack by default #4227
Merged
+33
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the workaround that was added to Chrome in #2361 by default as it significantly reduces audio quality and largely breaks audio spatialization. It remains as a preference but we should plan to remove it once a fix lands upstream (which is slated for this year) https://bugs.chromium.org/p/chromium/issues/detail?id=687574
It is unclear if this was always an issue or something that changed in Chrome that caused this workaround to cause other issues... I am hoping for my own sanity that its the later, though it has been an issue since at least January since it was mentioned by a user on the original PR #2361 (comment)
Incidentally adds ability to the preference screen to have dependent properties: