Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Change Scene" button is missing once the scene is set from a GLB #4235

Merged

Conversation

rawnsley
Copy link
Contributor

@rawnsley rawnsley commented May 6, 2021

Once a custom GLB URL is used to set the scene for a room, the scene cannot be set again to either an existing scene or another GLB URL.

This is particularly restrictive when rapidly iterating new scene files as you have to create a new room for each scene version.

Initial Room Info Dialog
Screenshot 2021-05-06 at 15 30 31

Room Dialog After Using Custom Scene File
Screenshot 2021-05-06 at 15 30 50

Room Edit Dialog After Using Custom SceneFile
Screenshot 2021-05-06 at 15 30 57

@netpro2k netpro2k merged commit 0eda787 into Hubs-Foundation:master Jun 3, 2021
@netpro2k
Copy link
Contributor

netpro2k commented Jun 3, 2021

Thanks! I definitely noticed that one when testing locally once but forgot to file it.

@Softvision-GeluHaiduc
Copy link
Contributor

I have verified this issue using Firefox 89.0 and Chrome 90.0.4430.212 on Windows 10.
Now, the "Change Scene" button is present for the rooms created with the GLB scenes. An interesting thing I notice is that the original issue is not present on Hubs Cloud.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified-fixed Label for QA to mark verified fixed issues label Jun 7, 2021
@rawnsley rawnsley deleted the change-scene-after-custom-glb branch June 7, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[QA]:Verified-fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants