Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Three.js into r128 #4321
Bump Three.js into r128 #4321
Changes from 32 commits
96e5c29
dd91daa
d7b3b07
021031a
34e6cfc
e98ebb8
2c1ce20
1d1ef75
b3d6f81
01c6450
18c23d3
4ea709e
ddd1ba0
c43f2ea
d1c4f2f
ed8339b
41d3f9e
bc7e05c
e3efddb
7038476
741edfb
02498b4
e16c3f1
37021a1
e42ce42
c315804
959e9d0
e46019c
19b30ae
22af86c
873ffd1
b3e197a
8a36363
60ce1d4
8590e26
22db3b8
869c68a
5d850df
4343809
8462298
c9fb8db
1a2668f
ce00ffa
69cc235
027df04
c53c8c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for this PR, but I wonder if we should just use a single instance of HubsTextureLoader for the whole app.