keyboard.getLayoutMap() throws an exception in iFrame on Chrome #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…93 when in an iframe
netpro2k
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you host Hubs in an iframe you get a console error from keyboard.getLayoutMap():
I can't find any definitive reference to this behaviour, but here is an example fix in another code base.
Downgrading this to a warning with an explicit message at least stops us having to think about it every time it happens. The fact that keyboard remapping will not work inside an iframe on Chrome is going to be harder to actually fix.
┆Issue is synchronized with this Jira Task