Fix browser detection code in node.js #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is failing because of prettier errors in other parts of the code. I've run all the other test/build/lint steps locally to make sure they are okay. |
|
Correction: We do not need to fix this issue in the master branch, since the safari workaround was implemented in a different way in #4594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR will be merged into the hubs-cloud branch. There will be a separate PR for the master branch.
In the last Hubs Cloud release, we added some browser detection code to store.js to workaround issues with Safari. This code is also in the code path for
npm run login, but the detection code did not behave correctly in a node.js environment. This PR fixes that issue.