Update to ThreeJS 133 #4788
Merged
Update to ThreeJS 133 #4788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
commented
Oct 27, 2021
| flines.unshift("uniform vec3 hubs_InteractorTwoPos;"); | ||
| flines.unshift("uniform float hubs_Time;"); | ||
| shader.fragmentShader = flines.join("\n"); | ||
| shader.vertexShader = |
There was a problem hiding this comment.
We might consider moving these changes into a patch in three to avoid breaking like this in the future
netpro2k
commented
Oct 27, 2021
| @@ -327,7 +283,9 @@ THREE.Water = function(geometry, options) { | |||
| renderer.xr.enabled = false; // Avoid camera modification and recursion | |||
| renderer.shadowMap.autoUpdate = false; // Avoid re-computing shadows | |||
|
|
|||
| renderer.render(scene, mirrorCamera, renderTarget, true); | |||
| renderer.setRenderTarget(renderTarget); | |||
There was a problem hiding this comment.
This is the only actual change in this file. The rest are formatting changes which appear to have not been applied in the past... Are we even still using this?
|
do you know mozilla is working on a fix for this? mrdoob/three.js#22631 |
Good callout, hadn't noticed this issue in my testing but seems like we should maybe include mrdoob/three.js#22759 for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using our new update process to update to ThreeJS 133 (from 128)
See https://github.com/mrdoob/three.js/wiki/Migration-Guide#128--129 and up.
I have gone through the migration guide and list of changes in the Hubs repo, still need to check in our dependency repos, though things appear to be working correctly so far in my tests.