Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations #128

Closed
wants to merge 2 commits into from
Closed

Conversation

kitebuggy
Copy link

In preparation for v1.0, a move to HubSpot::<...> calls instead of historical Hubspot::<...> classes and methods. All "Hubspot" calls continue to work, but raise a deprecation warning.

I've defaulted to v2.0 to drop deprecated calls.

(Oh and I squeezed in a minor emacs backup files line in the .gitignore, sorry!)

@kitebuggy kitebuggy mentioned this pull request Jul 16, 2018
@cbisnett
Copy link
Collaborator

I think all of this can be accomplished easily by adding HubSpot = Hubspot to lib/hubspot-ruby.rb. I've seen this done with other gems where they was some casing they wanted to change but maintain the backwards compatibility.

@cbisnett
Copy link
Collaborator

Closing this in favor of #140.

@cbisnett cbisnett closed this Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants