Improved help text to fix issue #35, updated setup.py to fix issue #39 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
octopose/deploy.py
Outdated
| parser.add_argument('--wait', action="store_true", | ||
| help="Wait and poll for deploy. Octopose will continually poll the Octopus Deploy Tasks till they are complete") | ||
| parser.add_argument('--force', action='store_true', | ||
| help='Force deployment. Ensures the package is re-downloaded even if it is already deployed into the target environment') |
There was a problem hiding this comment.
Tiny one, can this say "Ensures the package is re-deployed even if the selected version is already deployed into the target environment"
domgreen
requested changes
Jul 18, 2018
domgreen
approved these changes
Jul 18, 2018
| parser.add_argument('--wait', action="store_true", help="Wait and poll for deploy") | ||
| parser.add_argument('--force', action='store_true', help='Force deployment') | ||
| parser.add_argument('--wait', action="store_true", | ||
| help="Wait and poll for deploy. Octopose will continually poll the Octopus Deploy Tasks till they are complete") |
| parser.add_argument('--wait', action="store_true", | ||
| help="Wait and poll for deploy. Octopose will continually poll the Octopus Deploy Tasks till they are complete") | ||
| parser.add_argument('--force', action='store_true', | ||
| help='Force deployment. Ensures the package is re-deployed even if the selected version is already deployed into the target environment') |
There was a problem hiding this comment.
environment. or remove from -e 👍
| parser.add_argument('--wait', action="store_true", | ||
| help="Wait and poll for deploy. Octopose will continually poll the Octopus Deploy Tasks till they are complete") | ||
| parser.add_argument('--force', action='store_true', | ||
| help='Force deployment. Ensures the package is re-deployed even if the selected version is already deployed into the target environment') | ||
| parser.add_argument('-v', '--verbose', action='store_true', help="Do not suppress logging from deploy scripts.") |
There was a problem hiding this comment.
I would update this message ... verbose says we are getting extra debug info IMO ... up to you guys. But would change to something along the lines of Verbose logging gives extra contextual output.
Also, what is the default on this arg? I get confused with this one ... by default we should not log at verbose level.
There was a problem hiding this comment.
Default is do not log at the verbose level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.