Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete frameworks and runtime identifiers from the project file #3

Closed

Conversation

smy-huddly
Copy link

This serves two purposes:

  • Get rid of obsolete stuff from the project
  • The runtime identifier "win" is not valid (afaik) and breaks publishing in the camera service

Copy link

@thomas-huddly thomas-huddly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep our changes to this repo minimal. Can we keep netstandard2.0;net46;?

to build and publish properly. I've hidden it behind a conditonal to
avoid it. Only tested with .net6 and .net8 so I have no idea how this
change affects building with other frameworks
@smy-huddly smy-huddly force-pushed the remove_obsolete_frameworks_and_identifiers branch from 01ead10 to 77bdc23 Compare February 20, 2024 10:14
@smy-huddly smy-huddly closed this Feb 20, 2024
@smy-huddly smy-huddly deleted the remove_obsolete_frameworks_and_identifiers branch February 20, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants