Replace rather than append envvars in check

Fixes r-lib#1914
HughParsonage · Jul 2, 2019 · ca09163 · ca09163
1 parent 89f8b87
commit ca09163
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # devtools 2.0.1.9000 - Development
 
+* `check()` now replaces existing environment variables rather than appending
+  them (#1914).
+
 # devtools 2.0.1
 
 This is a minor release mainly fixing bugs which snuck through in the devtools

diff --git a/R/check.R b/R/check.R
@@ -191,7 +191,7 @@ check_built <- function(path = NULL, cran = TRUE,
     show_env_vars(env_vars, trailing = FALSE)
   }
 
-  withr::with_envvar(env_vars, action = "prefix", {
+  withr::with_envvar(env_vars, action = "replace", {
     rcmdcheck::rcmdcheck(path,
       quiet = quiet, args = args,
       check_dir = check_dir, error_on = error_on