Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fy package #201

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Import fy package #201

merged 2 commits into from
Nov 5, 2019

Conversation

DaniWood
Copy link
Collaborator

@DaniWood DaniWood commented Nov 2, 2019

No description provided.

* validate_fys_permitted rather than idiosyncratic use of all_fy etc
* Remove some tests that conflict with fy error messages or internal functions
@DaniWood DaniWood requested a review from MattCowgill November 2, 2019 05:32
@todo
Copy link

todo bot commented Nov 2, 2019

make fy inherit character

# TODO: make fy inherit character
if (inherits(.subset2(orig, "fy_year"), "fy") &&
!inherits(.subset2(custom.series, "fy_year"), "fy")) {
orig <- copy(orig)[, fy_year := as.character(fy_year)]
}


This comment was generated by todo based on a TODO comment in f1cea8b in #201. cc @HughParsonage.

@todo
Copy link

todo bot commented Nov 2, 2019

fy should inherit 'character'

grattan/R/cpi_inflator.R

Lines 187 to 192 in f1cea8b

# TODO: fy should inherit 'character'
cpi.indices.new[, fy_year := as.character(fy_year)]
cpi.indices <-
rbindlist(list(cpi.indices, cpi.indices.new),
use.names = TRUE,


This comment was generated by todo based on a TODO comment in f1cea8b in #201. cc @HughParsonage.

Copy link
Collaborator

@MattCowgill MattCowgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@MattCowgill MattCowgill self-requested a review November 3, 2019 21:56
@DaniWood DaniWood merged commit 0232e2d into master Nov 5, 2019
@DaniWood DaniWood deleted the fys branch November 5, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants