Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization and multilingual support #12

Closed
gcushen opened this issue May 20, 2016 · 7 comments
Closed

Localization and multilingual support #12

gcushen opened this issue May 20, 2016 · 7 comments
Labels
enhancement

Comments

@gcushen
Copy link
Collaborator

gcushen commented May 20, 2016 •
edited
Loading

Dependent on gohugoio/hugo#1734 and gohugoio/hugo#2303 getting completed and accepted into an official Hugo release.

This would enable the theme to support multiple languages like 中文 and English, for example. It may also become much easier to edit the hard coded language strings used for some headers etc.
@gcushen
Copy link
Collaborator Author

gcushen commented May 24, 2016

In the meantime, commit d03e66c provides a partial solution by enabling homepage titles to be easily customized in config.toml.

@kulla
Copy link
Contributor

kulla commented Sep 13, 2016 •
edited
Loading

Documentation for i18n in Hugo: https://github.com/spf13/hugo/blob/master/docs/content/content/multilingual.md (so I do not have to look for this URL every time 😄 )

An example website: https://github.com/aubort/hugo/tree/multilingual-example/examples/multilingual

@kulla
Copy link
Contributor

kulla commented Sep 13, 2016 •
edited
Loading

I want to work on this feature. For testing I have created https://github.com/kulla/hugo-academic-example-multilingual (which is currently a copy of exampleSite but which I want to alter for using with the new i18n feature). (I just noticed that I can run hugo server --theme="../../" inside `exampleSite for rendering it. Therefore I do not need an additional repo 😄)

@gcushen How do you want to manage the work on this issue? I would recommend creating a new branch multilingual for which I regularly create new PRs. Do you think that's a good idea?

@kulla kulla mentioned this issue Sep 13, 2016
Closed
@kulla
Copy link
Contributor

kulla commented Sep 13, 2016 •
edited
Loading

I just created the branch multilingual for working on this issue... (Currently only the multilanguage support is enabled with the languages en and de). Thinks I am working on there:

  • fix lang attribute inside <html>
  • fix <meta name="author">
  • fix <meta name="description">
  • fix <title>
  • fix RSS-Links in <head>
  • translate "Toggle navigation"
  • translate menu bar
  • translate organization
  • translate section "interests"
  • translate section "education"
  • add <link rel="alternate"> tags for other language versions of a page
  • add language chooser in the navigation bar

@kulla kulla mentioned this issue Sep 15, 2016
Closed
@gcushen
Copy link
Collaborator Author

gcushen commented Oct 8, 2016

Wow, Hugo v0.17 just got officially released 😃 Much faster than I expected!

@jsilence
Copy link

Also interested in a multilingual version of this theme and willing to collaborate and contribute. Where would be my best starting point?
Has the multilingual branch of Kullas fork been pulled into this repo?

@gcushen
Copy link
Collaborator Author

gcushen commented Nov 26, 2016 •
edited
Loading

Hi @jsilence , thanks for your interest in contributing.

It looks like @kulla almost finished the localization/multi-lingual feature in his fork, but he is currently busy with other projects.

Perhaps the best way forward is for you to fork his fork, bring it up-to-date with master, implement the remaining features in his to-do list (above) and submit it here as a pull request for me to review :)

@gcushen gcushen mentioned this issue Dec 19, 2016
Closed
5 tasks
gcushen added a commit that referenced this issue Dec 19, 2016
@gcushen
Add internationalization (i18n) support (#12)
31f9ce5
@gcushen gcushen closed this as completed Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsilence @kulla @gcushen