Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Font Awesome from v5.15.3 to v6 #2650

Merged
merged 1 commit into from
Mar 9, 2022
Merged

feat: update Font Awesome from v5.15.3 to v6 #2650

merged 1 commit into from
Mar 9, 2022

Conversation

rodrigoalcarazdelaosa
Copy link
Contributor

@rodrigoalcarazdelaosa rodrigoalcarazdelaosa commented Mar 4, 2022

Purpose

This PR updates Font Awesome to its latest version, following instructions found here, addressing #2649. v6 is fully compatible with v5, so no issues are expected. The yarn.lock file has also been updated installing the package via npm.

@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Deploy Preview for markdown-slides canceled.

🔨 Explore the source changes: ad3c7df

🔍 Inspect the deploy log: https://app.netlify.com/sites/markdown-slides/deploys/622209c8d6c5190007d52823

@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Deploy Preview for hugo-portfolio-theme canceled.

🔨 Explore the source changes: ad3c7df

🔍 Inspect the deploy log: https://app.netlify.com/sites/hugo-portfolio-theme/deploys/622209c862f9b500071070da

@rodrigoalcarazdelaosa
Copy link
Contributor Author

rodrigoalcarazdelaosa commented Mar 5, 2022

@gcushen if we're just using free icons perhaps we could take the opportunity to select just the CSS files for the styles we need to cut down on file size and improve performance, as suggested here.

@gcushen
Copy link
Collaborator

gcushen commented Mar 5, 2022

@gcushen if we're just using free icons perhaps we could take the opportunity to select just the CSS files for the styles we need to cut down on file size and improve performance, as suggested here.

I don't know how big the performance benefit is of including FontAwesome's new all.css vs specific files? Users who want to optimise performance still have the opportunity to remove all unused CSS with Hugo's PostCSS/PurgeCSS feature.

For open source projects, it looks like FA recommend including these 4 CSS files: https://fontawesome.com/docs/web/setup/host-yourself/webfonts#version-5-compatibility . If we go that route, it might be a good idea to use Hugo's CSS processing capability to concatenate those 4 CSS files together... Also, anyone wishing to use the Pro icons should still be able to do so by adding the Pro-specific CSS via the Custom Head feature.

@rodrigoalcarazdelaosa
Copy link
Contributor Author

rodrigoalcarazdelaosa commented Mar 6, 2022

For my part then, I'd include now the whole all.min.css file, which gives us compatibility with v5 too, since we have PostCSS and Font Awesome may become optional once Bootstrap 5 is added. Let me know @gcushen if anything else is needed to merge this PR. Thanks!

@gcushen gcushen merged commit acd5e74 into HugoBlox:main Mar 9, 2022
@gcushen gcushen changed the title Update Font Awesome to v6 feat: update Font Awesome from v5.15.3 to v6 Mar 9, 2022
@gcushen gcushen added this to the v5.5 milestone Mar 9, 2022
@rodrigoalcarazdelaosa rodrigoalcarazdelaosa deleted the fontawesome6 branch April 27, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants