New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Halpy-111] Case Management Commands & Notes #336

Merged

Rixxan merged 33 commits into develop from feature-halpy/111

Apr 9, 2023

Member

Rixxan commented Mar 17, 2023

Relies upon #334

Key Features:

Establishes the base Case Management commands for changing static aspects of Cases.
Adds commands needed for Case Note Management to automatically fill some details of cases for notes.
Automatically appends new note entries on key commands.
Establishes the KFType and CaseType Enums
Announcer now raises 400 Bad Request on invalid KingFisher coordinates

Also includes:

A new configuration option to specify rescue channels, which should be subsets of joined channels.
Improvements to the Board List command to allow platform or case type filtering.
Removes a significant amount of now-redundant Debug code.
Defines a number of new potential exception types for different situations.
If a Client announcement is to include an IRC name, include that name in the announcement.
Adds the Case Type to the initial case creation.
Updates the Planet Coords and KF Type to use the proper Enums
Refactors the get_case function to Packages from Commands
Adds a new Enum value for Inactive cases.

Future Enhancements to be Investigated:

Confirmation Loops on Some Commands

Closes #327, #111

Rixxan added 22 commits

March 11, 2023 18:36


          [Halpy-111] Add Rename and IRCN Update Commands

6f2e1da

Also includes logic to announce IRCN if different, catch more invalid IRCNs, and begin automatic processing of notes.


          [Halpy-327] Reorder Notes for Appended

6aa0d76


          [Halpy-327] Remove Append

f7aa006

What was I thinking, we don't need this...


          [Halpy-111] Add System Change Util

2a09c7c


          [Halpy-327] Include Prev Value

687a20f


          [Halpy-111] Add Status Command

8f84929


          [Docs] Update Docstring

a9fd298


          [Docs] Type Hint Sender

c4daa29


          [Halpy-111] Case Type Change and Hull Commands

e646980

Also adds a CaseType enum, included by default on new cases. Removes the Debug board stuff, since we can recreate most of this functionality now.


          [Halpy-328] Humanize the Enums

0d52acf


          [Halpy-111] No ctx.reply from packages

b812a51


          [Halpy-111] Add Platform command

80e1188


          [Halpy-111] Condense Enum Translation

e103490


          [Halpy-327] Note Management First Pass

a6d4b84


          [Halpy-111] Reject Coordinate Misforming

242e2a9


          [Halpy-111] KF Planet and Coords

a864dd6


          [Halpy-111] O2 Timer

cb175fb


          [Halpy-111] Add Synth command and filter ListBoard

ef07cf9


          [Halpy-111] Integrate Landmark in System Change

c4dafb1


          [Halpy-111] KFType Change Command

da698b2


          [Halpy-111] Canopy Status Command

8da3f0d


          [Halpy-111] Update Bool Check

5b5f809

Signed-off-by: David Sangrey <rixxan@hullseals.space>

Rixxan added enhancement feature sacm labels

Rixxan added this to the 2.0 milestone

Rixxan self-assigned this


          [Halpy-111] Add Gather Case Decorator

f3ea05a

Rixxan mentioned this pull request

[Consolodation] Refactor Exceptions #337

Merged

Rixxan linked an issue

that may be closed by this pull request

Edit Key Case Information #111

Closed

Rixxan linked an issue

that may be closed by this pull request

Manage Case Notes #327

Closed

Rixxan changed the title ~~Draft: [Halpy-111] Case Management Commands & Notes~~ [Halpy-111] Case Management Commands & Notes

Rixxan marked this pull request as ready for review

March 19, 2023 23:46


          Merge branch 'develop' into feature-halpy/111

Rixxan requested review from theunkn0wn1 and rik079

March 23, 2023 23:23

Rixxan mentioned this pull request

[Halpy-326] Responder Management #338

Merged

theunkn0wn1 reviewed

View reviewed changes

halpybot/commands/caseutils.py Show resolved Hide resolved

halpybot/commands/caseutils.py Show resolved Hide resolved

halpybot/commands/caseutils.py Outdated

Comment on lines 126 to 137

+                  filtered_cases = [
+                      case
+                      for case in caseboard.values()
+                      if (not list_filter)
+                      or (
+                          list_filter
+                          in (
+                              case.platform.name.casefold().replace("_horizons", ""),
+                              case.case_type.name.casefold(),
+                          )
+                      )
+                  ]

Contributor

theunkn0wn1 Mar 25, 2023

The cognitive complexity of this expression is very high. consider refactoring.

halpybot/commands/caseutils.py Outdated

+                  else:
+                      list_filter = None
+                  filtered_cases = [

Contributor

theunkn0wn1 Mar 25, 2023

[optimization] replace the list comprehension with a series of generator expressions.
This will allow you to reduce the cognitive complexity and increase expressiveness.
It also turns your current 2 * O(n) into an O(n)

halpybot/commands/caseutils.py Outdated Show resolved Hide resolved

halpybot/commands/caseutils.py Outdated Show resolved Hide resolved

halpybot/commands/caseutils.py Show resolved Hide resolved

halpybot/commands/caseutils.py Outdated Show resolved Hide resolved

halpybot/commands/caseutils.py Outdated Show resolved Hide resolved

halpybot/packages/announcer/announcer.py Show resolved Hide resolved

Rixxan and others added 3 commits

March 25, 2023 18:53


          [Halpy-336] Tuple to Dict

0b7a4a5

Co-authored-by: Joshua Salzedo <thHunkn0WNd@gmail.com>
Signed-off-by: David Sangrey <davidsangrey@gmail.com>


          [Halpy-111] Simplify Case Notes Update

cc55ef1

Co-authored-by: Joshua Salzedo <thHunkn0WNd@gmail.com>
Signed-off-by: David Sangrey <davidsangrey@gmail.com>


          [Halpy-111] Simplify Notes Mgmt

d79b154

Co-authored-by: Joshua Salzedo <thHunkn0WNd@gmail.com>
Signed-off-by: David Sangrey <davidsangrey@gmail.com>

Rixxan force-pushed the feature-halpy/111 branch from cdee7e9 to d79b154 Compare

March 25, 2023 23:22

Rixxan added 3 commits

March 25, 2023 23:01


          [Halpy-111] Fix Almost-Dangerous Chained Logical

dce2ff4


          [Halpy-111] Simplify HSKF Lookup

fe52230


          [Halpy-111] Simplify List Filter

5502e13

Rixxan force-pushed the feature-halpy/111 branch from 401d61c to 5502e13 Compare

March 26, 2023 03:54

Rixxan added 2 commits

March 25, 2023 23:58


          [Halpy-111] Remove Unneeded if args check

61881b9


          [Halpy-111] Further Refine ListBoard

7b95fff

theunkn0wn1 approved these changes

View reviewed changes

halpybot/commands/caseutils.py

+                  """Utilities for Wrapping EDSM Commands"""
+                  @staticmethod
+                  def gather_case(len_args_expected: int):

Contributor

theunkn0wn1 Apr 9, 2023

this len_args_expected thing feels bugprone, I am not convinced it should even be a thing.

halpybot/commands/caseutils.py Outdated Show resolved Hide resolved

halpybot/commands/caseutils.py Outdated Show resolved Hide resolved

halpybot/commands/caseutils.py Outdated Show resolved Hide resolved


          [Halpy-111] Improved Implementations

a7852d8

Co-Authored-By: Joshua Salzedo <joshuasalzedo@gmail.com>

Rixxan mentioned this pull request

Improve Gather Case Decorator #339

Open

Rixxan merged commit 5949aef into develop

Rixxan deleted the feature-halpy/111 branch

April 9, 2023 19:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature sacm