-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
@@ -13,8 +13,11 @@ module.exports = function excludeBlacklisted() { | |||
if (usersettings.total <= 0){ | |||
return hook; | |||
} | |||
const blacklist = usersettings.data[0].blacklist; | |||
hook.params.query.userId = {$nin: blacklist}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the query.userId
got overwritten
for some strange reason
Where does that come from? I cannot see any |
9962068
to
65f907d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem's ok, on fast look
Why against develop and nich master was it’s a hotfix. |
params.userId comes from feathers! Do not alter it!(at least not without extra really taking care) |
@appinteractive it's |
@roschaefer yeah you are right! But search for When you are changing it, you would have to not overwrite it but merge it like so:
|
@appinteractive I thought this is exactly what I did in the PR. Though, you code is a one-liner while I need two lines. |
Okay now I see it, just saw the removed part, not the new one somehow. |
Still, hotfix for master or develop only? |
I still don't understand why this does not happen on the server...