chore(cypress): Favor firefox in cypress #3121
Conversation
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
I merged #3119 and if that lets all the dependency PRs pass, I'd say let's close this?
| "cypress:run": "cross-env cypress run", | ||
| "cypress:open": "cross-env cypress open", | ||
| "cypress:run": "cross-env cypress run --browser firefox", | ||
| "cypress:open": "cross-env cypress open --browser firefox", |
There was a problem hiding this comment.
That has the drawback that we cannot record our cypress tests anymore 😢 can we close?
There was a problem hiding this comment.
No, actually it doesn't, if you look at the build, or click on cypress, you can see that all the videos were recorded
There was a problem hiding this comment.
I wouldn't close, is there any justifiable reason to use a different browser than what we recommend our users to use for e2e tests?
cypress/integration/common/report.js
Outdated
| @@ -169,7 +169,7 @@ Then('each list item links to the post page', () => { | |||
| Then('I can visit the post page', () => { | |||
| cy.contains(annoyingUserWhoMutedModeratorTitle).click() | |||
| cy.location('pathname').should('contain', '/post') | |||
| .get('h3').should('contain', annoyingUserWhoMutedModeratorTitle) | |||
| .get('.ds-card-content .hyphenate-text').should('contain', annoyingUserWhoMutedModeratorTitle) | |||
There was a problem hiding this comment.
Could be, yes.
It failed locally, but that was in headless. Also, I was reading cypress docs and they suggest to never use tags as selectors.
We could open another PR to clean up our cypress code though
mattwr18
changed the title
roschaefer
force-pushed
the
favor-firefox-in-cypress
branch
from
482001d to
073d986
Compare
- we have recommended our users to use firefox, so why should we test in Electron?
mattwr18
force-pushed
the
favor-firefox-in-cypress
branch
from
073d986 to
2516da5
Compare
| @@ -169,7 +169,7 @@ Then('each list item links to the post page', () => { | |||
| Then('I can visit the post page', () => { | |||
| cy.contains(annoyingUserWhoMutedModeratorTitle).click() | |||
| cy.location('pathname').should('contain', '/post') | |||
| .get('title').should('contain', annoyingUserWhoMutedModeratorTitle) | |||
| .get('.base-card .title').should('contain', annoyingUserWhoMutedModeratorTitle) | |||
There was a problem hiding this comment.
not related to this PR directly, but not even sure how this was passing!? the title doesn't have a . indicating it's a class 🤷♀️
| "baseUrl": "http://localhost:3000", | ||
| "env": { | ||
| "RETRIES": 2 | ||
| } |
There was a problem hiding this comment.
Also, not related to firefox as a test runner, but unless I'm missing something, does anyone think retries are actually occurring? hopefully, we can see some evidence that this works
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
🍰 Pullrequest
Issues
Todo