Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): make locations spec more resilient #3324

Merged

Conversation

mattwr18
Copy link
Member

🍰 Pullrequest

Fixes build... do not hard code the id's as they are subject to change from mapbox's side.
it is enough that the ids contain either place, region, country

Issues

  • None

Todo

  • None

@cypress
Copy link

cypress bot commented Mar 23, 2020



Test summary

66 0 0 0


Run details

Project Human-Connection
Status Passed
Commit 2c997b2
Started Mar 23, 2020 8:04 PM
Ended Mar 23, 2020 8:30 PM
Duration 25:42 💡
OS Linux Ubuntu Linux - 16.04
Browser Firefox 68

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Mar 23, 2020



Test summary

66 0 0 0


Run details

Project Human-Connection
Status Passed
Commit ad3b4e0 ℹ️
Started Mar 23, 2020 8:25 PM
Ended Mar 23, 2020 8:48 PM
Duration 23:05 💡
OS Linux Ubuntu Linux - 16.04
Browser Firefox 68

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This surely does the trick. I am still asking myself how we suddenly receive different ids from mapbox.

@mattwr18
Copy link
Member Author

This surely does the trick. I am still asking myself how we suddenly receive different ids from mapbox.

yeah, I think that's strange, I wonder if this means that we are going to be creating multiple identical locations because the id's have changed 🤷‍♀️

@mattwr18 mattwr18 merged commit 91f58cf into master Mar 24, 2020
@mattwr18 mattwr18 deleted the fix-broken-build-make-locations-spec-more-resilient branch March 24, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants