Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with permissions for editing models #277

Closed
appukuttan-shailesh opened this issue Jul 27, 2020 · 2 comments
Closed

Problem with permissions for editing models #277

appukuttan-shailesh opened this issue Jul 27, 2020 · 2 comments
Assignees

Comments

@appukuttan-shailesh
Copy link
Collaborator

When I try to access a public model with my test account (no admin privileges), the “Edit” button is still active. It doesn’t let me save the changes (I get a message saying I’m not a member of the collab), but it would be better if the pencil icon wasn’t shown.

Currently the only check for "edit" (pencil icon) it so see if the model or test instance is editable (no results linked to them), and there is no user based checks.

@apdavison might implemenet a new endpoint in the API for checking access.
Awaiting above end-point before proceeding on this task.

@appukuttan-shailesh
Copy link
Collaborator Author

The same end-point could probably help handle #262 as well.

apdavison added a commit to apdavison/hbp-validation-framework that referenced this issue Sep 14, 2020
@apdavison
Copy link
Member

This has been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants