Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New way of deploying GCFs breaks make deploy #943

Closed
hannes-ucsc opened this issue Feb 1, 2018 · 2 comments · Fixed by #988
Closed

New way of deploying GCFs breaks make deploy #943

hannes-ucsc opened this issue Feb 1, 2018 · 2 comments · Fixed by #988
Assignees
@xbrianh
Labels
BUG

Comments

@hannes-ucsc
Copy link
Contributor

This change

844cb5f#diff-b0fbe298c4db83b2781689861c9efc93R63

broke make deploy on Travis:

https://travis-ci.org/HumanCellAtlas/data-store/builds/336192169#L3134

A related comment

#924 (comment)

I will be backing this change out for the time being.
@hannes-ucsc hannes-ucsc added the BUG label Feb 1, 2018
hannes-ucsc added a commit that referenced this issue Feb 1, 2018
@hannes-ucsc
Revert "use gcloud command to deploy GCF (#924)" (connected to #943)
e20686e 
This reverts commit 844cb5f.
@hannes-ucsc
Copy link
Contributor Author

Consensus on Slack was that we use a newer method that's now available for deploying GCFs: a PUT to a signed URL. Then the dependence on the fixture bucket (which was the primary motivator for PR #924) can be eliminated without depending on the gcloud utility.

@hannes-ucsc
Copy link
Contributor Author

https://cloud.google.com/functions/docs/reference/rest/v1beta2/projects.locations.functions/generateUploadUrl describes that method.

xbrianh pushed a commit that referenced this issue Feb 9, 2018
use signed url to deploy GCF event relay (#943)
bed7125
xbrianh pushed a commit that referenced this issue Feb 12, 2018
use signed url to deploy GCF event relay (#943)
6eb5d4f
xbrianh pushed a commit that referenced this issue Feb 13, 2018
use signed url to deploy GCF event relay (#943)
abbc337
xbrianh pushed a commit that referenced this issue Feb 13, 2018
use signed url to deploy GCF event relay (#943)
c69a3ad
xbrianh pushed a commit that referenced this issue Feb 13, 2018
use signed url to deploy GCF event relay (#943)
ab4fc66
xbrianh pushed a commit that referenced this issue Feb 14, 2018
use signed url to deploy GCF event relay (#943)
74ab83d
xbrianh pushed a commit that referenced this issue Feb 16, 2018
use signed url to deploy GCF event relay (#943)
fa0198e
@xbrianh xbrianh mentioned this issue Feb 16, 2018
Merged
@ghost ghost added code review labels Feb 16, 2018
xbrianh pushed a commit that referenced this issue Feb 16, 2018
Use signed url to deploy GCF event relay (#943)
8339011
xbrianh pushed a commit that referenced this issue Feb 20, 2018
Use signed url to deploy GCF event relay (#943)
3536a53
xbrianh pushed a commit that referenced this issue Feb 20, 2018
Use signed url to deploy GCF event relay (fixes #943)
2a21498
xbrianh added a commit that referenced this issue Feb 21, 2018
@xbrianh
Remove GCF deployment deps on fixtures bucket 2 (#988)
a3dd80d 
* Bump requirements
+certifi==2018.1.18
+cryptography==2.1.4
+google-apitools==0.5.21

* Use signed url to deploy GCF event relay (fixes #943)
* GCF Deploy checked on 5s interval instead of 1s
@ghost ghost removed the in progress label Feb 21, 2018
xbrianh pushed a commit that referenced this issue Feb 22, 2018
Use signed url to deploy GCF event relay (fixes #943)
132a5de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xbrianh xbrianh

Labels
BUG
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove GCF deployment deps on fixtures bucket 2 HumanCellAtlas/data-store
2 participants
@hannes-ucsc @xbrianh