Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename API_HOST to API_DOMAIN_NAME #1016

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Rename API_HOST to API_DOMAIN_NAME #1016

merged 1 commit into from
Feb 28, 2018

Conversation

xbrianh
Copy link
Member

@xbrianh xbrianh commented Feb 28, 2018 •
edited
Loading

Renamed in anticipation of allowing functional deployments
without creating a custom domain name.

connects to #856

Test plan

Rename API_HOST to API_DOMAIN_NAME
a97f8ca 
Renamed in anticipation of allowing functional deployments
without creating a custom domain name.
@ghost ghost assigned xbrianh Feb 28, 2018
@ghost ghost added the in progress label Feb 28, 2018
hannes-ucsc
hannes-ucsc approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you hold off on merging this until tomorrow (2/28) morning?

@hannes-ucsc
Copy link
Contributor

Merge anytime.

@xbrianh xbrianh merged commit f75b65c into master Feb 28, 2018
@ghost ghost removed the in progress label Feb 28, 2018
@xbrianh xbrianh deleted the bhannafi-rename-api-host branch March 21, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannes-ucsc hannes-ucsc hannes-ucsc approved these changes

@kislyuk kislyuk kislyuk approved these changes

Assignees

@xbrianh xbrianh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xbrianh @hannes-ucsc @kislyuk