Deploy custom domain with Terraform #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xbrianh
force-pushed
the
bhannafi-infra-domain
branch
2 times, most recently
from
a2ea229 to
dbb3611
Compare
Terraform does not support regional domain names. As a workaround, use a Terraform "null_resource" to call a custom provisioning script to set up a custom regional domain name and Route 53 record.
xbrianh
force-pushed
the
bhannafi-infra-domain
branch
from
dbb3611 to
e3b6838
Compare
xbrianh
changed the title
|
Reviewers may find documentation for terraform During testing, after successful execution of |
kislyuk
approved these changes
May 21, 2018
kislyuk
reviewed
May 21, 2018
| #!/usr/bin/env python | ||
|
|
||
| """ | ||
| This script configures a regional domain name for AWS Apigateway, based on an existing |
There was a problem hiding this comment.
The full human-readable name for the service is "API Gateway" and I would prefer it if we used it consistently throughout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy a regional API Gateway custom domain name through scripting executed by the Terraform workflow.
This is a workaround while waiting for Terraform support for regional domains:
hashicorp/terraform-provider-aws#2195
#connect to #856