Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch infra tweaks #1240

Merged
merged 1 commit into from
May 16, 2018
Merged

Elasticsearch infra tweaks #1240

merged 1 commit into from
May 16, 2018

Conversation

xbrianh
Copy link
Member

@xbrianh xbrianh commented May 16, 2018 •
edited
Loading

Update TF script to reflect currently deployed elasticsearch domain and logging.

connects to #856

@xbrianh xbrianh requested review from mweiden and Bento007 May 16, 2018 00:20
@xbrianh xbrianh self-assigned this May 16, 2018
mweiden
mweiden approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@mweiden mweiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. In the future please split the refactors from the environment changes and make the commits a little bit more descriptive so I can catch up to where you're at.

@xbrianh
Copy link
Member Author

xbrianh commented May 16, 2018

@mweiden 👍

@xbrianh xbrianh merged commit 2be2724 into master May 16, 2018
@xbrianh xbrianh deleted the bhannafi-infra-elasticsearch-access_ips branch May 16, 2018 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweiden mweiden mweiden approved these changes

@Bento007 Bento007 Awaiting requested review from Bento007

Assignees

@xbrianh xbrianh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xbrianh @mweiden