Script for setting up Apigateway base path maping #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A script for idempotently mapping the AWS Apigateway custom domain name to the Apigateway stage. It should be executed for a first-time deployment after successfully running `make deploy-infra` and `make deploy`.
hannes-ucsc
approved these changes
May 22, 2018
| #!/usr/bin/env python | ||
|
|
||
| """ | ||
| This script idempotently maps the AWS Apigateway custom domain name to the Apigateway |
There was a problem hiding this comment.
Nit: Apigateway is a really odd spelling. Amazon API Gateway is the official spelling.
| stage = os.environ['DSS_DEPLOYMENT_STAGE'] | ||
| domain_name = os.environ['API_DOMAIN_NAME'] | ||
|
|
||
| APIGATEWAY = boto3.client('apigateway') |
There was a problem hiding this comment.
Nit: The convention of upper-casing variables referencing boto3 clients objects has no precedence in this project. I would suggest sticking with the existing convention or filing a PR that establishes this convention consistently across the project after motivating it to the team.
There was a problem hiding this comment.
@Bento007 started upper-casing non-constants so we now have zero an annoying degree of inconsistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A script for idempotently mapping the AWS Apigateway custom domain name to the Apigateway stage. It should be executed for a first-time deployment after successfully running
make deploy-infraandmake deploy.#connect to #856