Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EZ] Add Subscription Cleanup #408

Merged
merged 1 commit into from
Aug 2, 2019
Merged

[EZ] Add Subscription Cleanup #408

merged 1 commit into from
Aug 2, 2019

Conversation

amarjandu
Copy link
Contributor

clean subscription after creation on login logout test.

@amarjandu amarjandu changed the title Add Subscription Cleanup [EZ] Add Subscription Cleanup Jul 30, 2019
Copy link
Contributor

@DailyDreaming DailyDreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wait til the dss is fixed and tests are passing.

@kozbo kozbo added this to the Q3 2019 Milestone 2 milestone Jul 31, 2019
@codecov-io
Copy link

codecov-io commented Aug 1, 2019

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files          39       39           
  Lines        1844     1844           
=======================================
  Hits         1576     1576           
  Misses        268      268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59a513...7dd9f42. Read the comment docs.

@amarjandu amarjandu merged commit a496e08 into master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants