Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify how hca cache is cleared #431

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Modify how hca cache is cleared #431

merged 2 commits into from
Aug 26, 2019

Conversation

Bento007
Copy link
Member

  • Changed refresh_swagger to clear_cache
  • Fixed type in clear_cache documentation
  • Adding clear-hca-cache to CLI to clear the cache of all SwaggerClients subclasses.
  • Updated tests and tutorials.

@Bento007 Bento007 requested a review from kislyuk August 19, 2019 16:57
@Bento007 Bento007 self-assigned this Aug 19, 2019
@Bento007
Modify how hca cache is cleared
2b798b0 
- Changed refresh_swagger to clear_cache
- Fixed typo in clear_cache documentation
- Adding clear-hca-cache to CLI to clear the cache of all SwaggerClients subclasses.
- Updated tests and tutorials.
@Bento007 Bento007 force-pushed the tsmith-clear-cache branch from 03a1801 to 2b798b0 Compare August 19, 2019 16:58
@codecov-io
Copy link

codecov-io commented Aug 19, 2019 •
edited
Loading

Codecov Report

Merging #431 into master will decrease coverage by 0.11%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   85.72%   85.61%   -0.12%     
==========================================
  Files          39       39              
  Lines        1857     1863       +6     
==========================================
+ Hits         1592     1595       +3     
- Misses        265      268       +3
Impacted Files Coverage Δ
hca/cli.py 63.55% <100%> (+0.62%) ⬆️
hca/util/__init__.py 86.82% <100%> (ø) ⬆️
hca/__init__.py 57.14% <25%> (-42.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af1a66...ef9a655. Read the comment docs.

kislyuk
kislyuk approved these changes Aug 25, 2019
View reviewed changes
Copy link
Member

@kislyuk kislyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending minor changes, thanks.

hca/__init__.py Outdated Show resolved Hide resolved
hca/util/__init__.py Outdated Show resolved Hide resolved
@Bento007 Bento007 merged commit 7a6f774 into master Aug 26, 2019
@Bento007 Bento007 deleted the tsmith-clear-cache branch August 26, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kislyuk kislyuk kislyuk approved these changes

Assignees

@Bento007 Bento007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bento007 @codecov-io @kislyuk