Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import dependencies #483

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Fix import dependencies #483

merged 2 commits into from
Nov 5, 2019

Conversation

DailyDreaming
Copy link
Contributor

Hard-coding this as per the old behavior. I'll leave it to Charles if he wants to modify this in the future and attempt to adjust the cascade of dependencies that importing __version__ requires.

chmreid
chmreid approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@chmreid chmreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will look into alternative ways of specifying the version number in one place and more consistently

chmreid
chmreid approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@chmreid chmreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will look into alternative ways of doing this

chmreid
chmreid approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@chmreid chmreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will look into alternative ways of doing this

chmreid
chmreid approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@chmreid chmreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will look into alternative ways of doing this

chmreid
chmreid approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@chmreid chmreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will look into alternative ways of doing this

chmreid
chmreid approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@chmreid chmreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will look into alternative ways of doing this

@chmreid
Copy link
Contributor

chmreid commented Nov 5, 2019

I am not a bot

@DailyDreaming DailyDreaming merged commit ba502d8 into master Nov 5, 2019
@chmreid
Copy link
Contributor

chmreid commented Nov 5, 2019

This should probably have been reverted back to 6.5.0 and not 6.6.0dev: https://github.com/HumanCellAtlas/dcp-cli/pull/476/files#diff-2eeaed663bd0d25b7e608891384b7298L10

@DailyDreaming DailyDreaming mentioned this pull request Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmreid chmreid chmreid approved these changes

@amarjandu amarjandu Awaiting requested review from amarjandu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DailyDreaming @chmreid