Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to query service #504

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Remove references to query service #504

merged 3 commits into from
Jan 23, 2020

Conversation

MDunitz
Copy link
Contributor

@MDunitz MDunitz commented Jan 23, 2020

  • remove query service references and tests
  • set default config to point at dss swagger

@MDunitz MDunitz requested a review from amarjandu January 23, 2020 22:05
@codecov-io
Copy link

codecov-io commented Jan 23, 2020 •
edited
Loading

Codecov Report

Merging #504 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
- Coverage   85.67%   85.63%   -0.05%     
==========================================
  Files          42       40       -2     
  Lines        1906     1893      -13     
==========================================
- Hits         1633     1621      -12     
+ Misses        273      272       -1
Impacted Files Coverage Δ
hca/cli.py 62.72% <ø> (-0.67%) ⬇️
hca/__init__.py 50% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b04d05...1f29b95. Read the comment docs.

amarjandu
amarjandu approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@amarjandu amarjandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 thing otherwise LGTM.

hca/default_config.json Outdated
@@ -5,7 +5,7 @@
"swagger_url": "https://dss.data.humancellatlas.org/v1/swagger.json"
},
"DCPQueryClient": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key DCPQueryClient can be removed from this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MDunitz MDunitz merged commit 700234d into master Jan 23, 2020
@MDunitz MDunitz deleted the remove-qs-test branch January 23, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarjandu amarjandu amarjandu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MDunitz @codecov-io @amarjandu