Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend atlas names #1584

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

Extend atlas names #1584

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e9198c
Extend atlas names
arschat Oct 9, 2024
1c2ecfa
Fixed hca_tissue_atlas examples to match enum values
arschat Oct 9, 2024
2a9cfa9
Remove Eye - Other atlas name
arschat Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/jsonBrowser/module.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ Location: module/project/hca_bionetwork.json
Property name | Description | Type | Required? | Object reference? | User friendly name | Allowed values | Example
--- | --- | --- | --- | --- | --- | --- | ---
name | HCA Bionetwork the project is a part of (e.g. Kidney). | string | no | | Official HCA Bionetwork | Adipose, Breast, Development, Eye, Genetic Diversity, Gut, Heart, Immune, Kidney, Liver, Lung, Musculoskeletal, Nervous System, Oral & Craniofacial, Organoid, Pancreas, Reproduction, Skin | Kidney; Lung
hca_tissue_atlas | A field describing if the project is part of a HCA Tissue Atlas (e.g. Brain Alzheimer Atlas). | string | no | | HCA Tissue Atlas | Blood, Retina, Lung, Kidney, Gut, Eye, Brain | Blood Atlas
hca_tissue_atlas | A field describing if the project is part of a HCA Tissue Atlas (e.g. Brain Alzheimer Atlas). | string | no | | HCA Tissue Atlas | Adipose, Blood, Brain, Breast, Development, Eye, Eye - Other, GDN, Gut, Heart, Immune, Kidney, Liver, Lung, MSK, ORCF, Organoid-Endoderm, Organoid-Neural, Pancreas Retina, Reproduction, Skin | Retina
hca_tissue_atlas_version | A field describing which version of the HCA Tissue Atlas is associated with the project (e.g. v1.0; v2.0) | string | no | | Official HCA Tissue Atlas Version | | v1.0; v2.0
atlas_project | A field describing if this project is the HCA Tissue Atlas project which integrates data from other datasets. | boolean | no | | Project Tissue Atlas Status | | Yes; No

Expand Down
31 changes: 23 additions & 8 deletions json_schema/module/project/hca_bionetwork.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,32 @@
"description": "A field describing if the project is part of a HCA Tissue Atlas (e.g. Brain Alzheimer Atlas). ",
"type": "string",
"enum": [
"Adipose",
"Blood",
"Retina",
"Lung",
"Kidney",
"Gut",
"Brain",
"Breast",
"Development",
"Eye",
"Brain"
],
"Eye - Other",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove "Eye - Other"; this will be refined as the atlas becomes more focused.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Dave! Done.

"GDN",
"Gut",
"Heart",
"Immune",
"Kidney",
"Liver",
"Lung",
"MSK",
"ORCF",
"Organoid-Endoderm",
"Organoid-Neural",
"Pancreas",
"Retina",
"Reproduction",
"Skin"
],
"user_friendly": "HCA Tissue Atlas",
"guidelines": "For example: Blood Atlas",
"example": "Blood Atlas"
"guidelines": "For example: Retina",
"example": "Retina"
},
"hca_tissue_atlas_version": {
"description": "A field describing which version of the HCA Tissue Atlas is associated with the project (e.g. v1.0; v2.0)",
Expand Down
1 change: 1 addition & 0 deletions json_schema/update_log.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Schema,Change type,Change message,Version,Date
module/project/hca_bionetwork,patch,Extend atlas names in hca_bionetwork,,
Copy link
Collaborator

@ESapenaVentura ESapenaVentura Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revisit what minor/patch updates are like. Thanks for following the guide https://github.com/HumanCellAtlas/metadata-schema/blob/master/docs/evolution.md#schema-versioning but I think extending an enumeration is not a patch change, as in my opinion any change in the schema that involves change in the validation rules should be at least a minor change. Anyways, this is good to go as per our specs! 🥇

Loading